-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove number of deprecated parameters/functions/classes [fix #6641] #6813
Conversation
Wanted to double-check that you want me to remove |
can certainly leave that for now FYI also need to check/update vbenches for any of these deprs |
Not sure what the vbenches are? Is that what's in the vb_suite directory? If so, here are the two places with FutureWarning
You don't want me to delete those do you? |
@jsexauer - let's leave out deprecating |
i.e. you can just open a separate PR that handles the refactor and deprecation for |
yearfirst=yearfirst) | ||
else: | ||
data = tools.to_datetime(data, errors='raise') | ||
data.offset = offset | ||
data.offset = freq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is slightly confusing to me - we deprecated offset
as a parameter but not the actual offset
property on the object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct; there is no notation I can find that says the offset property of the pandas Timestamp object is deperated. However, freq is an alias of offset:
https://github.com/pydata/pandas/blob/master/pandas/tslib.pyx#L258
Ok I will do the |
can you edit #6581 to update the >= 0.12 (that we are going to deprecate in the future)? thanks |
anyone have a problem with any of this, these are all removed deprecations that were in effect <= 0.11 (so a while ago). That were announced to be removed in a future version. @jsexauer @jtratner @jorisvandenbossche @TomAugspurger @cpcloud @hayd @wesm |
Looks good, but I don't see the |
@cpcloud It is the second to last item in the "Deprecated since 0.12" list. I see that the warning message says to remove in 0.14, but warning was given only in 0.13. Let me know if you want me to remove anyways. |
oh ok ... you're right ... sorry i haven't looked at html stuff in a while, carry on |
yep....only doing < 0.12 announced deprecations (which their are a lot!) |
I'm pretty wary of removing |
save/load not on the table as those where from. 0.12 @jsexauer in the list can u out the version that the depr happened (I know I have the commit but for reference) thanks |
@wesm I don't own a copy of The Book unfortunately, but assuming it was written for v0.9 (given publish in Oct 2012) the only two of these that might affect it are
Do you know if either of these were used? @jreback Modified inital PR comment to include versions of first deprecation. Also moved all deprecations not pulled out in this PR into #6581. |
Neither of those are used in wes' book. |
yep...i think this is all fine. |
thanks @jsexauer |
@jsexauer ok..this is merged, but can you do a follow up fix the issues in v0.14.0 (and prob in release.rst), so that they are the original issues numbers (and not the deprecation issue). http://pandas-docs.github.io/pandas-docs-travis/whatsnew.html#whatsnew-0140-prior-deprecations e.g. if you are looking thru that page you want to be able to click thru and see what the original issue was. |
What should I do for the ones that that didn't have issues? |
if u have a commit reference then u can use that (though u may have to do an inline reference) |
Have an example you could point me to? |
oh...looking in cookbook.rst, its just another external link. (The issues render differently/automatically, via the issue number), but a commit is just a reference like any other HTML link. |
Fixes #6641
Line numbers as of commit 70de129:
Deprecated since 0.11 or before
The following are fixed in this PR:
.\pandas\core\format.py:{2143}
.\pandas\core\format.py:{442, 369}
.\pandas\core\frame.py:{1387, 1342, 1283}
.\pandas\core\frame.py:{1285, 1133}
.\pandas\core\series.py:{910}
.\pandas\io\pytables.py:{691}
.\pandas\stats\moments.py:{554}
.\pandas\tseries\frequencies.py:{247}
.\pandas\core\daterange.py:{24} (will be done in DEPR: Deprecate DateRange #6816)
.\pandas\io\data.py:{344}
.\pandas\tseries\index.py:{180}
Deprecated since 0.12 or after
Issue #6581 documents the following for future removal. These are not included in this PR
Deprecate na_last in favor of na_position (EHN/FIX: Add na_last parameter to DataFrame.sort. Fixes GH3917 #5231, BUG: Nested sort with NaN #3917).\pandas\core\series.py:{1770}
Deprecate rolling_corr_pairwise and expanding_corr_pairwise (Pairwise versions for rolling_cov, ewmcov and expanding_cov #4950).\pandas\stats\moments.py:{301,957}
Deprecate broadcasting TimeSeries along DataFrame index (Broadcasting bug with datetime.date index? #2304).\pandas\core\frame.py:{2837}
Deprecate load and save in favor of pickle and to_pickle (CLN deprecate save&load in favour of to_pickle&read_pickle #3787).\pandas\core\common56.py:{2740, 2756}
.\pandas\core\generic.py:{960, 967}
Deprecate timeRule and offset in favor of freq (tshift does not work for Panels #4853, Panel tshift 4853 #4864).\pandas\core\datetools.py:{55}
Deprecate colSpace in favor of col_space (no issue, commit 4a5a677).\pandas\core\frame.py:{1292,1346,1392}
Deprecate year/month parameters in finance option signatures (Change Finance Options signatures and deprecate year/month parameters #3822, backwards compatible refactoring of io/data options functionality #3817).\pandas\io\data.py:{588,811,848}
Remove kind from read_excel (CLN: Remove unused and undocumented kind keyword from read_excel #4713).\pandas\io\excel.py:{103}
Deprecate infer_types to have no effect (REF/BUG/ENH/API: refactor read_html to use TextParser #4770).\pandas\io\html.py:{830}
Deprecate table keyword in HDFStore (API: remove the table keyword, replaced by fmt='s|t' #4645).\pandas\io\pytables.py:{1124}